Fixed #29 Lithium breaks stray cat behavior. #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of the bug is that the entity tracker is not checking whether the predicate returns true when evaluating which entity is the closest. The predicate is usually responsible for filtering out certain entities (spectators, or sometimes entities that cannot be seen using raycast, entities on the same team). Not testing the predicate leads to incorrect behavior, as for example, cats usually can't flee from spectators or creative mode players.
The fix adds checking the predicate and the given box (tracking distance of most things is only +-3 on the y axis) after the minimal distance criterion.
Of course this fix will cost some performance, but I don't see a way to get around evaluating the predicate more often than absolutely necessary without sorting the entities by distance first. Also caching the result does not seem viable, because keeping track when the cached value becomes outdated would be required.