new: Optimize block entity ticking & unloading #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2No2Name
requested changes
Aug 19, 2020
src/main/java/me/jellysquid/mods/lithium/common/util/collections/HashSetBackedList.java
Outdated
Show resolved
Hide resolved
…ther mods running and avoid additional bugs
2No2Name
approved these changes
Aug 19, 2020
src/main/java/me/jellysquid/mods/lithium/common/util/collections/HashedList.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new optimization patch that uses hash tables as a specifically optimized collection option for the list of unloaded block entities in the world, which greatly improves performance when unloading large numbers of them (also see MC-117075).
Based on my tests, it took about ~60% less time to unload a full chunk of chests than vanilla. However, my computer is too weak and the numbers may differ significantly from mine. But what I can say for sure is that it will definitely improve performance.
P. S. I am from another country and English is not my first language. If I made stupid mistakes, please correct me. I'll be very grateful.