Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map interaction performance improvements #944

Merged
merged 1 commit into from
Nov 22, 2016
Merged

Conversation

oliverroick
Copy link
Member

Proposed changes in this pull request

  • Resolves Improve performance of Leaflet.Deflate #932
  • Switch to a customized version of Leaflet.Deflate to improve the performance of map interactions. (These changes will be added upstream to Leaflet.Deflate at some point). The customized approach includes the following changes:
    • Ignore point features when evaluation whether to show the original feature or the marker.
    • Group features into bins according to the zoom threshold and evaluate only features that were affected by the last zoom action.
    • When evaluating, features ignore everything that is outside the current map view. When the map is panned, the current map view is re-evaluated and updated accordingly. The reevaluation only includes features that have not be evaluated before.
  • Removes Leaflet.MarkerCluster.LayerSupport as it is not needed any longer

I have tested this against a data set with 15,000 polygons of varying size and the Uttaran data set.
Uttaran is almost exclusively points; the performance is increased tremendously. The performance of the polygons dataset is reasonable; for instance, takes roughly 350ms to replace ~4000 polygons when looking at an area approximately the size of Hamburg .

When should this PR be merged

For sprint 11

Risks

None

Follow up actions

None

@ian-ross ian-ross merged commit 7f1742f into master Nov 22, 2016
@ian-ross ian-ross deleted the enhancement/#932 branch November 22, 2016 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants