Install argon2 support and set as default algorithm #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverroick
force-pushed
the
security/#876
branch
from
3b9361e to
a16c387
Compare
oliverroick
approved these changes
Jan 3, 2017
There was a problem hiding this comment.
Most of the changes introduces with this PR originate from #1015, a lot of which are my changes. I would suggest to test this in staging to test functionality and then have someone else look over the code when we have confirmed everything is working.
amplifi
force-pushed
the
security/#876
branch
from
a16c387 to
da23bef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Installs the Argon2 pip package and overrides the Django default hashing algorithms to prioritize Argon2. (Resolves #876)
When should this PR be merged
Merge with PR for Django 1.10.4 upgrade
Risks
Very low; Django continues to support all previous algorithms, and any passwords hashed using the old default (PBKDF2) will be automatically converted to use Argon2 next time the user logs in.
Follow up actions
We should consider comms -- sending an email to current production users prompting them to log in, so that as many passwords as possible will be updated to use Argon2. For the same reason, Cadasta staff with production accounts should log in after this change is released.