Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First cut at permissions policies #88

Merged
merged 3 commits into from
Mar 15, 2016

Conversation

ian-ross
Copy link
Contributor

Covers organisations, projects and users. This goes with the information on the wiki page at https://github.com/Cadasta/cadasta-platform/wiki/Permissioning-policies and is intended to cover at least the first part of #8 -- there will be more permissions-related stuff as we implement new features.

@ian-ross ian-ross force-pushed the feature/permissioning-policies branch from 5f551d9 to a2f69d8 Compare March 14, 2016 12:27
Covers organisations, projects and users.
@oliverroick
Copy link
Member

I fixed some syntax errors, a few commas were missing.

Two questions/remarks on this:

  1. I don't get the purpose of project-user. It has less permissions than default. Is it supposed to be used together with other policies?
  2. The data-collector role needs some more actions I think, such as project.data.add or project.data.edit. We need to remember to add those when we work on surveys.

@ian-ross
Copy link
Contributor Author

That was a lot of syntax errors! Cut-and-paste-itis, for sure.

Answers to questions:

  1. The idea of the project-user role was for "normal" users attached to a project. If there's no role associated with attaching a user to a project, it seems like it's a no-op. And yes, the idea is for policies to stack: everyone gets the default policy, then other roles and policies are applied on top. That's true for all the policies. Let me edit the policies a bit to make things more explicit.
  2. Yes: there are going to be lots more actions for all sorts of things. I didn't think there was much point in trying to guess what they would all be in advance. I'm planning to add them to that big table in the wiki as we come up with new ones.

@ian-ross
Copy link
Contributor Author

I've added some comments to the policy files here, and some more text to the wiki page. I don't consider this "finished" in any sense -- it's more just something to get us moving in the right direction with these things.

@oliverroick
Copy link
Member

Ok, looks all good. I will merge this.

oliverroick added a commit that referenced this pull request Mar 15, 2016
@oliverroick oliverroick merged commit 3febb13 into master Mar 15, 2016
@oliverroick oliverroick deleted the feature/permissioning-policies branch March 15, 2016 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants