Fix #866 -- Makeing sure organizaiton roles are always unique #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add unique constraint to OrganizationRole model - Add integrity checks for unique constraints to serializers - Additional API tests
oliverroick
force-pushed
the
bugfix/organzation-api-members
branch
from
a5dd67b to
6a63afb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
This PR fixes a series of issues related to duplicate
OrganizationRolerecords. Creating duplicateOrganizationRolerecords was possible via the API, which resulted in exceptions being raised when accessing projects and projects list because the underlying logic expected only one organization role to be present per user and organization. The PR fixes the root cause; creating duplicate roles will not be possible any longer.When should this PR be merged
Anytime
Risks
There is a migration that adds a unique constraint on fields
user_idandorganization_idon tableorganization_organizationrole. There is a low risk that this migration fails if there already are duplicate entries in the database. Low risk because so far it's only possible to create these duplication items via the API but not through the site.Follow up actions
I would test this on staging against the production database before deploying to production.