Try to fix non-determinism in tests #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seav
reviewed
Oct 20, 2016
| @@ -47,6 +47,9 @@ class Resource(RandomIDModel): | |||
|
|
|||
| history = HistoricalRecords() | |||
|
|
|||
| class Meta: | |||
| ordering = ('name',) | |||
There was a problem hiding this comment.
Resources could have the same name so we still have a nondeterministic ordering. It may help to have the resource ID as the second field.
On the other hand, this ordering is simply to make testing deterministic. So if all our tests stick to unique resource names, then this should be OK.
There was a problem hiding this comment.
Exactly. It's just for testing.
seav
reviewed
Oct 20, 2016
| @@ -0,0 +1,23 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Didn't we agree that: "No more auto migrations, please!"
There was a problem hiding this comment.
Crap. You're right. I'll rename it.
There was a problem hiding this comment.
Was just trying to do a quick and dirty fix...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Add ordering for resources to make database queries in tests deterministic.
When should this PR be merged
Right away, if it works.
Risks
Has a database migration, but it's completely innocuous.
Follow up actions
None.