Allow accounts loadpolicies command to be run on its own #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the arguments, when running `python manage.py loadpolicies`, you
get a `KeyError`:
```
Traceback (most recent call last):
File "manage.py", line 10, in <module>
execute_from_command_line(sys.argv)
File "/home/karen/cadasta/env/lib/python3.5/site-packages/django/core/management/__init__.py", line 353, in execute_from_command_line
utility.execute()
File "/home/karen/cadasta/env/lib/python3.5/site-packages/django/core/management/__init__.py", line 345, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/home/karen/cadasta/env/lib/python3.5/site-packages/django/core/management/base.py", line 348, in run_from_argv
self.execute(*args, **cmd_options)
File "/home/karen/cadasta/env/lib/python3.5/site-packages/django/core/management/base.py", line 399, in execute
output = self.handle(*args, **options)
File "/home/karen/cadasta-platform/cadasta/accounts/management/commands/loadpolicies.py", line 10, in handle
load.run(force=options['force'], update=options['update'])
KeyError: 'force'
```
Close #836
|
@karenc Good stuff, thanks for spotting and fixing this. It is much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Add arguments for accounts loadpolicies command
Without the arguments, when running
python manage.py loadpolicies, youget a
KeyError:Close Error running manage.py loadpolicies #836
When should this PR be merged
When review is complete.
Risks
There shouldn't be any.
Follow up actions
If this pull request is accepted, we should look at other
management/commandsdirectories for other commands that have the same problem.