Display user's full name on user list page #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse user creation code whether user is a superuser or not. Apply the superuser role if user is indeed supposed to be a superuser. Display user's full name on user list page Under the "member" column, it used to show only the user's username, now it's showing "username (full name)". Close #316
|
Thanks for your contribution @karenc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Refactor functional tests user creation code
Reuse user creation code whether user is a superuser or not. Apply the
superuser role if user is indeed supposed to be a superuser.
Display user's full name on user list page
Under the "member" column, it used to show only the user's username, now
it's showing "username (full name)".
Close User list page should also display the user's full name #316
Screenshot from original user list page:
Screenshot after proposed changes:
When should this PR be merged
No preconditions
Risks
There shouldn't be any.
Follow up actions
None