Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #794: Avoid error when superuser views org member edit page #806

Merged
merged 1 commit into from
Oct 10, 2016

Conversation

seav
Copy link
Contributor

@seav seav commented Oct 7, 2016

Proposed changes in this pull request

  • Fix Superuser cannot view org member edit page #794:
    • Add exception handling to OrganizationMembersEdit.get_context_data() to avoid the error when the user is a superuser.
    • Add a unit test to catch this bug and to verify that it is fixed.
  • Disable the org role select form field when the viewing user is an org admin viewing his/her own member page.

When should this PR be merged

Anytime.

Risks

None foreseen.

Follow up actions

None.

@ian-ross ian-ross merged commit 9381e8c into master Oct 10, 2016
@ian-ross ian-ross deleted the bugfix/#794 branch October 10, 2016 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superuser cannot view org member edit page
2 participants