Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pre_delete to detach resources from records #804

Merged
merged 2 commits into from
Oct 10, 2016

Conversation

linzjax
Copy link
Contributor

@linzjax linzjax commented Oct 6, 2016

Proposed changes in this pull request

When should this PR be merged

Whenever

Risks

None

Follow up actions

There is commented out code for whenever we implement resources for PartyRelationship and SpatialUnitRelationship

@seav
Copy link
Contributor

seav commented Oct 6, 2016

Couple of comments:

  1. "detatch" ➡ "detach"
  2. The receivers all have the same body. Is it possible to DRY these things out?

@linzjax
Copy link
Contributor Author

linzjax commented Oct 7, 2016

Gosh darn my spelling... Thank you for ctatchting...
I looked at trying to put it into the mixin but couldn't quite make it work. I'll give it another go.

@linzjax linzjax force-pushed the bug/#803-detached-resources branch from e66ce01 to c4e03c0 Compare October 7, 2016 15:07
@ian-ross ian-ross force-pushed the bug/#803-detached-resources branch from a22e47d to f083e4f Compare October 10, 2016 06:57
@ian-ross ian-ross merged commit f6b17e2 into master Oct 10, 2016
@ian-ross ian-ross deleted the bug/#803-detached-resources branch October 10, 2016 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants