Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to user accounts #798

Merged
merged 4 commits into from
Oct 18, 2016
Merged

Improvement to user accounts #798

merged 4 commits into from
Oct 18, 2016

Conversation

oliverroick
Copy link
Member

@oliverroick oliverroick commented Oct 6, 2016

Proposed changes in this pull request

  • Bump django-skivvy to 0.1.2
  • Fixes Email verification for user accounts not recorded #766 -- Records email verification
    • The User.email_verified field is set to True when the email is verified.
  • Send email and deactivate user if email is not confirmed
    • If the email is not verified within 48 hours and the user tries to login, the account is deactivated and a new confirmation email is sent. (I wasn't sure about the account deactivation, happy to change it if anyone thinks we shouldn't do it.)
    • The account will be activated when the email is confirmed.
  • Fix Send confirmation email when user changes their email address #676 -- Send confirmation email when email is changed
    • When the user changes their email address a email to confirm the address is sent. The email must be confirmed within 48 hours.
  • Fix Inactive account page shown but no confirmation email received #821 -- Add migration to activate user accounts when the email has been confirmed

When should this PR be merged

Anytime. But someone should thoroughly test the whole signup -> confirmation -> email change process. It easy to miss something there/

Risks

  • Low risk, no migrations.

Follow up actions

None.

@oliverroick
Copy link
Member Author

I've just pushed a renamed migration file (according to our new policy), this is ready to go from my end.

@oliverroick oliverroick force-pushed the bugfix/#766 branch 2 times, most recently from cb43983 to 5478db8 Compare October 17, 2016 15:16
- Fixes #766 -- Records email verification
- Send email and deactivate user if email is not confirmed
- Fix #676 -- Send confirmation email when email is changed
- Bump django-skivvy to 0.1.2
@ian-ross ian-ross merged commit bb57158 into master Oct 18, 2016
@ian-ross ian-ross deleted the bugfix/#766 branch October 18, 2016 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants