Caching for tutelary #747
Merged
Caching for tutelary #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-ross
force-pushed
the
enhancement/tutelary-caching
branch
6 times, most recently
from
db767f5 to
b3101db
Compare
ian-ross
force-pushed
the
enhancement/tutelary-caching
branch
from
b3101db to
19d7dbd
Compare
ian-ross
force-pushed
the
enhancement/tutelary-caching
branch
from
19d7dbd to
6ed926f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
The cache configuration in this PR at the moment is set up the same for development and production. For development, this is the correct
DummyCachebackend. For production, this needs to be updated to usememcachedoncememcachedis included in the provisioning setup.When should this PR be merged
This PR should not be merged until @amplifi has modified it to include
memcachedsetup in the production provisioning scripts.Risks
There shouldn't be any risk to this. It's just caching, and before these changes, django-tutelary wasn't doing any across-process cache invalidation of its internal caches, so this can only make things better!
Follow up actions
I don't know how to do this, but it would be good to have some diagnostics to demonstrate that the cache is really working.