Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InlineManual changes #634

Merged
merged 1 commit into from
Sep 2, 2016
Merged

InlineManual changes #634

merged 1 commit into from
Sep 2, 2016

Conversation

clash99
Copy link
Contributor

@clash99 clash99 commented Sep 2, 2016

Proposed changes in this pull request

  • Replaced embedded inlinemanual player with standalone
  • Added unique id and removed link to "i" in header to put add help functionality in inlinemanual

When should this PR be merged

As convenient

Risks

  • Only risk I can foresee is having info link not work while changeover is happening

Follow up actions

  • Need to coordinate this test with some inlinemanual changes to ensure it works on all different sites - staging, demo and production

Changed player from embedded to standalone. Added unique id for help
and detached from cadasta.org page.

InlineManual changes
0fd9c58 
Changed player from embedded to standalone.  Added unique id for help
and detached from cadasta.org page.
@ian-ross ian-ross merged commit 9395bd5 into master Sep 2, 2016
@ian-ross ian-ross deleted the enhancement/#622 branch September 2, 2016 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clash99 @wonderchook @ian-ross