Tidy up provisioning and loadstatic thing #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-ross
force-pushed
the
tidying/loadstatic
branch
from
5bbc9c9 to
fbf4842
Compare
|
Looks good to me; ship it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
loadstaticmanagement command.--forceflag to theloadstaticmanagement command. If static data database entities already exist,loadstaticwill not make any changes unless this flag is supplied.django-jsonattrsversion to 0.1.10 to pick up version withforceflag in attribute type loading.dataprovisioning role for development only to ensure that newly created development VMs have the appropriate static data loaded.When should this PR be merged
Any time.
Risks
Low to none, but reviewer (@amplifi) should check that the Ansible provisioning steps that will run during deployment and redeployment will produce the expected results. In particular, the
loadstaticcommand is now not run from theaws-deploy.ymlAnsible playbook, so static data loading will need to be performed as an additional step during deployments.Follow up actions
None.