Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded player for demo site #600

Merged
merged 1 commit into from
Aug 24, 2016
Merged

Conversation

clash99
Copy link
Contributor

@clash99 clash99 commented Aug 24, 2016

Proposed changes in this pull request

This embeds player for inline manual that will only be effective on demo.cadasta.org

When should this PR be merged

As soon as possible - we need it for this sprint release.

Risks

I don't see any errors occurring on my host site so I don't think it should affect anything although there will be no benefits outside of the demo site.

Follow up actions

  • I will be creating tutorials in inlinemanual.com and once complete, should be able to publish from within there.
  • We should leverage people tracking and analytics options within inlinemanual.
  • Consider using a standalone player download. Spoke with @amplifi and with upbeat we will be able to track differences in page load times and focus on issues as they arise.

@ian-ross ian-ross merged commit ebb6612 into master Aug 24, 2016
@ian-ross ian-ross deleted the enhancement/player-inlinemanual branch August 24, 2016 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants