Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHP download #523

Merged
merged 1 commit into from
Aug 4, 2016
Merged

Add SHP download #523

merged 1 commit into from
Aug 4, 2016

Conversation

oliverroick
Copy link
Member

@oliverroick oliverroick commented Aug 3, 2016

Proposed changes in this pull request

  • Implements Shapefile Export #323
  • Add GDAL/OGR installation via Ansible
  • Introduces organization.download.shape.ShapeExporter, which exports project data to shapefile format.
  • Introduces organization.download.base.Exporter class for common export functionality. Both organization.download.shape.ShapeExporter and organization.download.xls.XLSExporter extend this class.
  • Adds shape export option to forms and templates

When should this PR be merged

This PR can be merged immediately. We should, however, check the following:

  • VM provisioning with GDAL/OGR works and is tested. I'd test it on another machine as well, just to be sure.
  • The copy on the download form should be checked by a native speaker.
  • The copy in the README template should be checked by a native speaker.

Risks

None/low risk.

Follow up actions

  • The installation of GDAL/OGR alongside PostGIS 2.1 can be problematic. I added the necessary steps to the Ansible playbook. We should test if GDAL/OGR installs correctly on our AWS instances before we roll out shape file export to production (/cc @amplifi)

- Add GDAL installation via Ansible
- Introduces `organization.download.shape.ShapeExporter`, which exports project data to shapefile format.
- Introduces `organization.download.base.Exporter` class for common export functionality. Both `organization.download.shape.ShapeExporter` and `organization.download.xls.XLSExporter` extend this class.
- Adds shape export option to forms and templates
@ian-ross ian-ross force-pushed the feature/shapefile-export branch from 699dab9 to de6007f Compare August 4, 2016 13:25
@ian-ross ian-ross merged commit b1a9489 into master Aug 4, 2016
@ian-ross ian-ross deleted the feature/shapefile-export branch August 4, 2016 13:55
@seav seav mentioned this pull request Aug 6, 2016
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants