Make OSM tile access be over HTTPS #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-ross
force-pushed
the
bugfix/https-for-osm-tiles
branch
2 times, most recently
from
184480f to
e6766eb
Compare
Keep on using HTTP for OSM in development to make Squid caching of tiles easy for functional testing.
ian-ross
force-pushed
the
bugfix/https-for-osm-tiles
branch
from
e6766eb to
ddaee55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Change the URL for the OSM tile server in the default settings to be an HTTPS URL instead of HTTP. Add code to the development and Travis settings to make these environments still use HTTP URLs for OSM tiles. (Rationale: @amplifi has now set up HTTPS on our production and production-like environments, and loading OSM tiles from the HTTP servers thus triggers a "page has insecure content" warning in the browser. This change fixes that. However, in development and staging, we use the Squid web cache to make sure that we only hit the OSM servers once for each tile that we need. This is particularly important during functional testing, because we experienced multiple intermittent errors in the past because of throttling of requests on the OSM end. Caching HTTPS requests appears to be quite a bit more complicated than caching HTTP requests, so requiring the use of HTTP URLs in the development and Travis environments is the simplest way to keep everything working.)
When should this PR be merged
I think this can be merged right away.
Risks
Few/none.
Follow up actions
None.