Improvements to file upload post processing #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,13 +82,43 @@ def file_type(self): | |||
|
|
|||
| @property | |||
| def thumbnail(self): | |||
| icon_url = ('https://s3-us-west-2.amazonaws.com/cadasta-platformprod' | |||
There was a problem hiding this comment.
Do you not want to make this URL something that lives in the settings?
- Fixes #355 — Adds standard thumbnails for various file types - Adds `video/mp4` to the list of accepted mime types for file upload - Improves process to create thumbnails. The file is now only downloaded for post processing when the mime-type indicates an image. - Adds a migration to change the mime_type field maximum length to 100, to make sure that users can add Office2007+ documents. - Add MIME_LOOKUPS setting, which provides a list of accepted file types and the corresponding default thumbnail. This setting is also used in resources.validators to validate mime types
oliverroick
force-pushed
the
enhancement/#335
branch
from
4a0185e to
6b81c13
Compare
|
@ian-ross Added your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
video/mp4to the list of accepted mime types for file upload