Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions policies and tests (fixes #303) #336

Merged
merged 1 commit into from
Jul 7, 2016
Merged

Conversation

ian-ross
Copy link
Contributor

@ian-ross ian-ross commented Jul 7, 2016

@oliverroick and @wonderchook Could you review the permissions policies (in cadasta/config/permissions) to check that they tally with what you think different classes of user should be able to do? I had to update a number of things, and I think it's now consistent and sensible, but it would be good for someone else to take a look.

By the way, you can get a full list of all the actions that are registered with tutelary by doing the following in the VM:

cd /vagrant/cadasta
./manage.py shell
from tutelary.engine import Action
print('\n'.join(sorted([str(a) for a in Action.registered])))

I've also had to comment out one method in the party relationships stuff to get the test coverage to 100%, just because there's no UI to test that stuff against yet, so there's no way to exercise that code path. (It was previously being incorrectly exercised because of Cadasta/django-tutelary#28 -- that's now fixed, and this PR also updates the tutelary version to get the new behaviour for 404 exceptions and removes some redundant code that was only being called because 404 exceptions were being swallowed by tutelary.)

@oliverroick
Copy link
Member

The policies look ok to me. Let's wait what @wonderchook says.

@wonderchook
Copy link
Contributor

Looks good to me.

@wonderchook wonderchook merged commit 109f8a0 into master Jul 7, 2016
@wonderchook wonderchook deleted the bugfix/#303 branch July 7, 2016 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants