Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial front-end setup and user authentication flows #3

Merged
merged 57 commits into from
Jan 28, 2016
Merged

Initial front-end setup and user authentication flows #3

merged 57 commits into from
Jan 28, 2016

Conversation

oliverroick
Copy link
Member

Do not merge yet, using this for review and discussions.

This is a huge PR that adds a front-end to Cadasta platform.

It introduces:

Open issues that will be addressed be merging:

  • The HTTP implemention does not handle network errors.
  • Djoser's implementation to update user profiles neither validates duplicate email addresses nor updates usernames. There is a separate endpoint to update the user name. I would suggest to integrate that into PUT /account/me/, otherwise we end up having two requests to update a user profile.
  • Implement "remember me" when logging in, token should be stored in SessionStorage when unticked.
  • Refactoring. Several components need refactoring to prepare for when the front-end gets more complex.
    • Reducer should be more modular. Each module should be responsible for updating only one aspect of the store.
    • Router should be more modular. Each module should be responsible for one part of the app.
  • Change email text for account verification, etc.
  • Replace model instantiation in tests with factories (use FactoryBoy)
  • Add front-end tests to Travis
  • Document steps to install and run front-end parts
  • Document how to use wrappers and Mixin (HTTP requests, DismissMessageMixin for now)

oliverroick and others added 30 commits December 7, 2015 15:43
@oliverroick
User registration and login
c974c26 
Extends djoser functionality to implement custom functionality for
email verification
@oliverroick
Account verification endpoint
16a4793
@oliverroick
Sends verification email when user updates their email address
7f4e9c0
Initial front-end dev setup
7038a4f
@oliverroick
ES6 Lint setup
44d5c3f
@oliverroick
Allow CORS headers for unsuccessful requests
4c928a5
@oliverroick
Simple Login/Logout
01877e0
@oliverroick
Dev Email server settings
2e85ae0
@oliverroick
Signup flow
5098c2f
@oliverroick
Update user profile information
fea383e
@oliverroick
Add access-allow-method to nginx config
e55790d
@oliverroick
Fix URL History handling for webpack dev server
927514d
@oliverroick
Component redirect
db24d6b 
Redirects to login page when user accesses a page that requires login.
Redirects to dashboard, when user is logged in and access landing page
@oliverroick
Change password components
61b555d
@oliverroick
Update Djoser settings with correct Domain
8587c51
@oliverroick
Rest password components
b78f039
@oliverroick
Activate account
d82dfdb
@oliverroick
Wrapper for fetch API calls
9cb7c63 
Removes boilerplate code from actions by wrapping fetch API calls into
request library
@oliverroick
Add Registration component
3637ee2 
Refactored the registration form into a dedicated component that is
imported in both the landing page and the registration page
@oliverroick
Show and hide loading state message
42e801a
@oliverroick
Handle HTTP errors in promise
53f789a
@oliverroick
Adjust account reducer to response including success state
7c402d4
@oliverroick
Handle failed login
44adaf6
@oliverroick
Remove unused actions
3086c58
@oliverroick
Refractor *done actions into *success actions
fb76733
@oliverroick
Rewrite HTTP wrapper
da5ce2b 
It wraps XMLHttpRequest in a Promise. The Promise is resolved upon
successful requests (HTTP code 200 - 299) and rejected otherwise.

Use:

```
return Request.get('/')
  .then(
    (success => handleSuccess(success),
    (error => handleError(error))
  )
```
@oliverroick
Adapt actions and reducer to new Request wrapper
d1a956b
@oliverroick
Remove fetch
11c7694
@oliverroick
Introduce redirect action that is handled by redirect middleware
c2a1ed1 
Removing redirects from actions improves action testability and
separation of concerns
@oliverroick
Render Registration error message
a6dea19
@ian-ross
Copy link
Contributor

@oliverroick Should we just merge this now? You've ticked all the tickboxes!

@oliverroick
Copy link
Member Author

@ian-ross I wanted to fix the imports before merging. We're importing the complete libraries at the moment, which results in massive bundles. I'm going to change it so we import what we actually need.

@ian-ross
Copy link
Contributor

@oliverroick OK! That makes sense. I just had a feeling that I ought to have merged this, since you'd done so much work on it. We'll merge it as soon as you're happy with it though.

ian-ross added a commit that referenced this pull request Jan 28, 2016
@ian-ross
Merge pull request #3 from Cadasta/feature/users-djoser
4ff63be 
Initial front-end setup and user authentication flows
@ian-ross ian-ross merged commit 4ff63be into master Jan 28, 2016
@ian-ross ian-ross deleted the feature/users-djoser branch February 2, 2016 18:56
@ian-ross ian-ross mentioned this pull request Aug 8, 2016
Merged
1 task
@clash99 clash99 mentioned this pull request Aug 19, 2016
Closed
@clash99 clash99 mentioned this pull request Dec 13, 2016
Closed
@amplifi amplifi mentioned this pull request Jul 13, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverroick @ian-ross