Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete and improve records API #270

Merged
merged 1 commit into from
Jun 28, 2016
Merged

Conversation

seav
Copy link
Contributor

@seav seav commented Jun 27, 2016

This PR includes the following general changes:

  • Added relationships API and unit tests
  • Improved permissions for existing spatial unit and party API
  • Updated policy files for the permissions
  • General refactoring of records API and unit tests to be much more consistent and reusable

Code review is requested as this is a large update.

@@ -41,6 +44,27 @@
'(?P<project_id>[-\w]+)/parties/',
include('party.urls.api.parties',
namespace='party')),
url(r'^organizations/(?P<organization>[-\w]+)/projects/'
'(?P<project_id>[-\w]+)/relationships/', include([
url(r'^spatial/$',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be included from urls.py from inside the party or spatial apps.

Copy link
Contributor Author

@seav seav Jun 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I will create a relationships.py file for this inside the party app.

@oliverroick oliverroick self-assigned this Jun 28, 2016
@seav seav force-pushed the feature/relationships branch 2 times, most recently from c5da018 to 9fe08c7 Compare June 28, 2016 14:28
@seav seav force-pushed the feature/relationships branch from 9fe08c7 to 39281a0 Compare June 28, 2016 14:53
@oliverroick oliverroick merged commit db9d1a5 into master Jun 28, 2016
@oliverroick oliverroick deleted the feature/relationships branch June 28, 2016 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants