Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text changes on account pages #218

Merged
merged 2 commits into from
Jun 6, 2016
Merged

Text changes on account pages #218

merged 2 commits into from
Jun 6, 2016

Conversation

clash99
Copy link
Contributor

@clash99 clash99 commented Jun 6, 2016

Portion of design updates - text changes...

@@ -2,4 +2,4 @@
{% load account %}

{% user_display user as user_display %}
<p><strong>{% trans "Note" %}:</strong> {% blocktrans %}you are already logged in as {{ user_display }}.{% endblocktrans %}</p>
<p class="alert alert-info">{% blocktrans %}You are currently logged in as <strong>{{ user_display }}.{% endblocktrans %}</strong></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nesting here is funny: the <strong> tag opens inside the blocktrans block and closes outside it.

@clash99
Copy link
Contributor Author

clash99 commented Jun 6, 2016

Thanks for the catch - corrected the closing tag placement.

@ian-ross ian-ross merged commit ec49265 into master Jun 6, 2016
@ian-ross ian-ross deleted the feature/css-accountpages branch June 6, 2016 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants