Fixes #196: Private projects only visible to organization members #214
Conversation
linzjax
commented
Jun 3, 2016
linzjax
commented
- Dashboard only displays projects the user has view access to.
- Organization dashboard only displays private projects if user is a member of that organization.
- Organization list view only shows number of public projects, unless the user is a member of a specific organization, in which case it shows the real amount.
- Added fixtures for private projects.
ian-ross
force-pushed
the
bugs/private-projects-display
branch
from
31d0d57 to
df3054b
Compare
| @register.filter(name='private') | ||
| def private(value): | ||
| projects = value.filter(access='public') | ||
| return projects.count() |
There was a problem hiding this comment.
I don't like this. It's better to avoid custom template tags unless you really need them. This looks like something that ought to be a method on the Organization model -- maybe private_project_count and all_project_count methods to cover the two cases you use in the template?
ian-ross
force-pushed
the
bugs/private-projects-display
branch
2 times, most recently
from
522e495 to
58c7f73
Compare
linzjax
force-pushed
the
bugs/private-projects-display
branch
2 times, most recently
from
1d5f4e9 to
69de03f
Compare
|
Fixed. Let me know if there's anything else. (That was much easier than whatever it was I was trying to do...) |
- Also only visible on organization dashboard if user is a member of that organization. - Added tests Organization list view now only shows number of public projects, unless the user is a member of a specific organization deleted templatetags. added methods to model
ian-ross
force-pushed
the
bugs/private-projects-display
branch
from
69de03f to
d406463
Compare
|
Looks good. Just waiting for tests to run again (I rebased after merging another PR), then I'll merge it. You might want to take a look at Two Scoops of Django if you've not already seen it. It's pretty good about guiding you away from complicated things to simpler solutions (that's where I got the "don't use custom templatetags" advice from -- I had one myself before, and ended up getting rid of it and simplifying things a bit too). |
