Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis.yml to work around Trusty changes #1616

Merged
merged 1 commit into from
Jun 29, 2017

Conversation

amplifi
Copy link
Contributor

@amplifi amplifi commented Jun 28, 2017

Proposed changes in this pull request

Travis has updated their Trusty env, see details: https://blog.travis-ci.com/2017-06-21-trusty-updates-2017-Q2-launch — this is why our builds are failing. I recommend we update our travis.yml to work around the change and use the previous version of the Trusty build through the end of this sprint, then add a task for next sprint to update in compatibility with the new build.

When should this PR be merged

ASAP

Risks

Very low; only affects Travis env, which is currently failing without this workaround.

Follow-up actions

Add a task for Sprint 19 to update our Travis config/tests for compatibility with the new build.

Checklist (for reviewing)

General

  • Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
  • Is the PR labeled correctly? It should have the migration label if a new migration is added.
  • Is the risk level assessment sufficient? The risks section should contain all risks that might be introduced with the PR and which actions we need to take to mitigate these risks. Possible risks are database migrations, new libraries that need to be installed or changes to deployment scripts.

Functionality

  • Are all requirements met? Compare implemented functionality with the requirements specification.
  • Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

  • Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
  • Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
  • Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

  • Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
  • If this is a bug fix, are tests for the issue in place? There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
  • If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

  • Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • Are all UI and API inputs run through forms or serializers?
  • Are all external inputs validated and sanitized appropriately?
  • Does all branching logic have a default case?
  • Does this solution handle outliers and edge cases gracefully?
  • Are all external communications secured and restricted to SSL?

Documentation

  • Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes must be documented in the Cadasta Platform Documentation.
  • Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented in the API docs.
  • Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

@oliverroick
Copy link
Member

So Travis fixed the issue. Should we nevertheless go ahead with this PR?

@amplifi
Copy link
Contributor Author

amplifi commented Jun 28, 2017

@oliverroick Re-running some of the failed builds; if they pass, let's close this one. Can always resurrect if it starts failing again for the same issue.

@amplifi
Copy link
Contributor Author

amplifi commented Jun 28, 2017

LGTM, closing

@amplifi amplifi closed this Jun 28, 2017
@amplifi amplifi reopened this Jun 29, 2017
@amplifi amplifi force-pushed the travis-trusty-workaround branch from 3061ee9 to 7200685 Compare June 29, 2017 20:53
@alukach alukach self-requested a review June 29, 2017 21:01
Copy link
Contributor

@alukach alukach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't fix my issue, however if this resolves other build failures then I'm 👍

@amplifi amplifi merged commit eacf47f into master Jun 29, 2017
@amplifi amplifi deleted the travis-trusty-workaround branch June 29, 2017 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants