KNU & Paduak font addition

[clash99]

Proposed changes in this pull request

• Partially completes Ability to display the "uncommon" fonts in the platform #1554
• Adds Padauk and Karen font for displaying data in platform

When should this PR be merged

ASAP

Risks

• Low

Follow-up actions

• We should develop a standard practice for handling obscure fonts on our platform - Madrid discussion?

Checklist (for reviewing)

General

• Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
• Is the PR labeled correctly? It should have the migration label if a new migration is added.
• Is the risk level assessment sufficient? The risks section should contain all risks that might be introduced with the PR and which actions we need to take to mitigate these risks. Possible risks are database migrations, new libraries that need to be installed or changes to deployment scripts.

Functionality

• Are all requirements met? Compare implemented functionality with the requirements specification.
• Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

• Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
• Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
• Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

• Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
• If this is a bug fix, are tests for the issue in place? There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
• If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

• Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
• Are all UI and API inputs run through forms or serializers?
• Are all external inputs validated and sanitized appropriately?
• Does all branching logic have a default case?
• Does this solution handle outliers and edge cases gracefully?
• Are all external communications secured and restricted to SSL?

Documentation

• Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes must be documented in the Cadasta Platform Documentation.
• Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented in the API docs.
• Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

[oliverroick]

This looks good code-wise. As discussed during the bug triage meeting, we need to circle back with @SteadyCadence if this sufficient or if more work is needed.

[clash99]

For testing purposes

Taking text from here and putting it into the platform for testing:

• KNU Unicode + PadaukW: https://jsfiddle.net/7fos5wua/10/show/

Should render text to match:

NOT:

[bjohare]

Looks good.

[alukach]

Question before we merge this: Do we actually need the KNU Unicode font? From my tests, it was actually useless and almost all rendering (with the exception of whitespace and period symbols) was done by Padauk.

• System Font: https://jsfiddle.net/7fos5wua/6/show/
• Google Noto: https://jsfiddle.net/7fos5wua/7/show/
• KNU Unicode: https://jsfiddle.net/7fos5wua/8/show/
• PadaukW: https://jsfiddle.net/7fos5wua/9/show/
• KNU Unicode + PadaukW: https://jsfiddle.net/7fos5wua/10/show/

Avoiding adding extra imports will help keep load time short.

[SteadyCadence]

I can look at this end of week. We may not need it but I want to look closely at the characters because they can be "too sticky" and unreadable. Also the vowels can be doubled instead of singled.

…

On Jun 14, 2017 9:23 PM, "Anthony Lukach" ***@***.***> wrote: Question before we merge this: Do we actually need the KNU Unicode font? From my tests, it was actually useless and almost all rendering was done by Padauk. - System Font: https://jsfiddle.net/7fos5wua/6/show/ - Google Noto: https://jsfiddle.net/7fos5wua/7/show/ - KNU Unicode: https://jsfiddle.net/7fos5wua/8/show/ - PadaukW: https://jsfiddle.net/7fos5wua/9/show/ - KNU Unicode + PadaukW: https://jsfiddle.net/7fos5wua/10/show/ Avoiding adding extra imports will help keep load time light. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1567 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYKfFvBEIf6LcjdL6zgdMXBxGdz3LMeoks5sD-zlgaJpZM4NxWvw> .