Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted date picker localization file url #1557

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Adjusted date picker localization file url #1557

merged 1 commit into from
Jun 6, 2017

Conversation

clash99
Copy link
Contributor

@clash99 clash99 commented Jun 2, 2017

Proposed changes in this pull request

When should this PR be merged

  • When convenient

Risks

  • Low

Follow-up actions

  • We should put this in a team discussion about external file sources. The con here was that they decided to add more versions of english, which in turn broke our link because the original was renamed. There is a certain maintenance involved with both moving this locally and keeping it external. Anyway, this is fixed for now in the simplest way possible.

Checklist (for reviewing)

General

  • Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
  • Is the PR labeled correctly? It should have the migration label if a new migration is added.
  • Is the risk level assessment sufficient? The risks section should contain all risks that might be introduced with the PR and which actions we need to take to mitigate these risks. Possible risks are database migrations, new libraries that need to be installed or changes to deployment scripts.

Functionality

  • Are all requirements met? Compare implemented functionality with the requirements specification.
  • Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

  • Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
  • Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
  • Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

  • Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
  • If this is a bug fix, are tests for the issue in place? There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
  • If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

  • Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • Are all UI and API inputs run through forms or serializers?
  • Are all external inputs validated and sanitized appropriately?
  • Does all branching logic have a default case?
  • Does this solution handle outliers and edge cases gracefully?
  • Are all external communications secured and restricted to SSL?

Documentation

  • Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes must be documented in the Cadasta Platform Documentation.
  • Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented in the API docs.
  • Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

Copy link
Contributor

@seav seav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes would not work as written. The following line was deleted and this is the one that actually declares the LANGUAGE_CODE template variable.

{% get_current_language as LANGUAGE_CODE %}

@clash99
Copy link
Contributor Author

clash99 commented Jun 2, 2017

@seav - Is this code not working for you? It is working for me. That variable is declared in base.html so I removed it from the individual pages.

@seav
Copy link
Contributor

seav commented Jun 3, 2017

Ah. I missed that. OK, this makes sense.

@amplifi amplifi merged commit 27ee39e into master Jun 6, 2017
@amplifi amplifi deleted the bug/#1539 branch June 6, 2017 10:05
laura-barluzzi pushed a commit that referenced this pull request Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants