Cleanup: test refactoring and test coverage #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test coverage: 100%!!!!
|
Good job @ian-ross. Here's your Pernickety Coder Of The Week award: 🏆 Well deserved! |
|
Good. That now gives me the moral authority to wag my finger at people if they break my perfect 100% record! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test coverage: 100%!!!!
I feel like I should write a bigger comment for such a big PR, but it really is mostly test refactoring, new tests, removal of some dead code, fixing some issues that turned up during test writing and:
✨ 💥 ✨ TEST COVERAGE TO 100%!!! ✨ 💥 ✨
Sorry, just had to say that again...