Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1262: Add links to member profiles from OrganizationDashboard page #1263

Merged
merged 1 commit into from
Mar 17, 2017

Conversation

niharika1995
Copy link
Contributor

Proposed changes in this pull request

Fixes #1262

  • Adds a CSS rule that shows each li element with a cursor pointer.
  • Add links to member page on the username.

When should this PR be merged

Anytime.

Risks

  • None

Follow up actions

[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]

  • None

Checklist (for reviewing)

General

  • Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
  • Is the PR labeled correctly? It should have the migration label if a new migration is added.
  • Is the risk level assessment sufficient? The risks section should contain all risks that might be introduced with the PR and which actions we need to take to mitigate these risks. Possible risks are database migrations, new libraries that need to be installed or changes to deployment scripts.

Functionality

  • Are all requirements met? Compare implemented functionality with the requirements specification.
  • Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

  • Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
  • Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
  • Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

  • Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
  • If this is a bug fix, are tests for the issue in place There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
  • If this is a new feature or a significant change to an existing feature has the manual testing spreadsheet been updated with instructions for manual testing?

Documentation

  • Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes must be documented in the Cadasta Platform Documentation.
  • Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented in the API docs.
  • Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

@niharika1995 niharika1995 changed the title Add links to member profiles from OrganizationDashbard page Fix #1262: Add links to member profiles from OrganizationDashbard page Mar 9, 2017
@niharika1995 niharika1995 changed the title Fix #1262: Add links to member profiles from OrganizationDashbard page Fix #1262: Add links to member profiles from OrganizationDashboard page Mar 9, 2017
@clash99 clash99 self-requested a review March 9, 2017 23:33
Copy link
Contributor

@clash99 clash99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @niharika1995 - thanks again for helping us.

The link is perfect - no changes there. Can we adjust the css so that the li hover has both the cursor and the background color change (similar to the table on the left). Right now I'm only seeing the cursor change on the username link.

Let me know if you have any questions. Thanks, Chandra

@niharika1995
Copy link
Contributor Author

niharika1995 commented Mar 9, 2017

@clash99 Made the requested change.
P.S. I am not sure why the cursor wasn't working for you in the first commit. Both cursor and bg should work correctly now.

Copy link
Contributor

@clash99 clash99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly - thanks again @niharika1995! I'm going to ask another dev team member to review and hopefully we are good to go.

@oliverroick oliverroick merged commit b7a2412 into Cadasta:master Mar 17, 2017
@niharika1995 niharika1995 deleted the bugfix/#1262 branch April 10, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link members on Organizational Overview page directly to member profile
4 participants