Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxyconf settings #1198

Merged
merged 2 commits into from
Mar 6, 2017
Merged

Add proxyconf settings #1198

merged 2 commits into from
Mar 6, 2017

Conversation

amplifi
Copy link
Contributor

@amplifi amplifi commented Mar 6, 2017

Proposed changes in this pull request

Adds proxyconf settings to Vagrantfile. Users behind proxies can install the vagrant-proxyconf plugin for provisioning the local dev VM. Users without proxies experience no changes.

When should this PR be merged

Anytime

Risks

None; users without proxies experience no changes. Only those with the vagrant-proxyconf plugin will obtain the new settings.

Follow up actions

Document plugin option in readme.

Checklist (for reviewing)

General

  • Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
  • Is the PR labeled correctly? It should have the migration label if a new migration is added.
  • Is the risk level assessment sufficient? The risks section should contain all risks that might be introduced with the PR and which actions we need to take to mitigate these risks. Possible risks are database migrations, new libraries that need to be installed or changes to deployment scripts.

Functionality

  • Are all requirements met? Compare implemented functionality with the requirements specification.
  • Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

  • Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
  • Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
  • Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

  • Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
  • If this is a bug fix, are tests for the issue in place There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
  • If this is a new feature or a significant change to an existing feature has the manual testing spreadsheet been updated with instructions for manual testing?

Documentation

  • Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes must be documented in the Cadasta Platform Documentation.
  • Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented in the API docs.
  • Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

Copy link
Member

@oliverroick oliverroick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a note to the README to let people know that they need to install vagrant-proxyconf when they are behind a proxy?

@amplifi
Copy link
Contributor Author

amplifi commented Mar 6, 2017

@oliverroick That was going to be my next PR. I've got it noted as a follow-up action here, but let me push it to this branch and ship it all in one.

@amplifi amplifi force-pushed the vagrant-proxy-settings branch from 18fba96 to 1424202 Compare March 6, 2017 14:24
@amplifi amplifi merged commit 2b3b601 into master Mar 6, 2017
@amplifi amplifi deleted the vagrant-proxy-settings branch March 6, 2017 15:20
laura-barluzzi pushed a commit to laura-barluzzi/cadasta-platform that referenced this pull request Mar 14, 2017
* Add proxyconf settings

* Specify versions and offer vagrant-proxyconf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants