Make it impossible to Create Duplicate Resource Entries

[laura-barluzzi]

Proposed changes in this pull request

Fixed issue Possible to Create Duplicate Resource Entries #1107

Inside the tag to attach a resource I did the following:

1. Added onclick="this.form.submit(); this.disabled=true;" so that the button gets disabled after the form has been submitted.

2. Changed name="submit" into name="submit-name" otherwise the system doesn't recognize submit() as a function.

When should this PR be merged

I double-checked the rest of the code to see if there're places where the button name needs to be updated as well. Although I haven't found any, it may be worth double-checking before merging.

[CLAassistant]

All committers have signed the CLA.

[oliverroick]

Hi @laura-barluzzi, thank you for your contribution. I have a change request:

Could you think of a way to turn this approach into a more generic form. I believe that it might be handy to have this functionality in an external script so we can reuse it in other forms as well. The way I would approach it is, instead of using onclick I would register an event handler on the submit of the form and disable the button in the handler function. It shouldn't be too difficult using jQuery.

[laura-barluzzi]

@oliverroick thanks for your suggestion. Sure I can do that, I'll work on it in the next days.

[oliverroick]

@laura-barluzzi One thing I just noticed: You've been committing work directly to the master branch of your repo, and you made the PR from master. That's not a good thing to do, because it can make it difficult to incorporate changes from the "upstream" Cadasta/cadasta-platform repository into your work, which you need to do to keep your PR branch up to date with other work that's going on in the main repo. The way to deal with this is to work on what people call a topic (or feature) branch. When you want to work on a feature, you check out your master branch, then do something like git checkout -b bugfix/#675, which makes a new branch with a mnemonic name, expecially for the work you're going to do, so that we can keep track of what's going on.

[laura-barluzzi]

@oliverroick thanks for telling me, I'll create a branch and work from that instead. Just to clarify, should I name the branch "bugfix/#1107"?

[laura-barluzzi]

@oliverroick I've been working on the solution and I was wondering if it's fine to combine both approaches so that I still use the onclick="onlySubmitOnce(this.form)" and I call the external function onlySubmitOnce(form) with the form passed as argument. Would this be acceptable?

[laura-barluzzi]

Follow up pull request (submitted from feature branch): #1191. Please review that pull request instead of this one.