-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Vector Tiling for SMAP #1099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good but there's one thing that bothers me (which is not your fault). The way L.TileLayer.GeoJSON
is set up, it sends a lot of requests the the server which need to be processed. This makes sense when you provide different levels of geometry generalisation for each zoom level but not for our case. We want to load the geometry once and then don't worry about it any more when the map is zoomed or panned.
I thought about this a little and the best way to solve this is to keep track of the areas that have been downloaded already. I'm trying to come up with an idea to solve this efficiently. I'll keep you posted.
593903f
to
c3236e4
Compare
adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view
b80a457
to
2f00b31
Compare
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
* implemented tile->lat/long converter adding L.Deflate back added L.TileLayer.GeoJSON and updated to be compatable with Leaflet 1.0 Currently only loaded spatial resources. Should update to drop SUs when out of view * Lazy tile loading
Note: Not going into master
Proposed changes in this pull request
When should this PR be merged
Whenever
Risks
None (Not going into master)
Follow up actions
Checklist (for reviewing)
General
migration
label if a new migration is added.Functionality
Code
Tests
Documentation