Adds PR review checklist #1007
Merged
Adds PR review checklist #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amplifi
suggested changes
Dec 15, 2016
|
@amplifi Added comment about migrations |
linzjax
approved these changes
Dec 15, 2016
| #### General | ||
|
|
||
| - [ ] **Is the PR labeled correctly?** It should have the `migration` label if a new migration is added. | ||
|
|
There was a problem hiding this comment.
Is this PR explained thoroughly? Are all the code changes accounted for in the description of the PR?
Maybe something about risk level? If it's a high risk, has this been taken into consideration?
There was a problem hiding this comment.
Good comments, I added those points
| #### Tests | ||
|
|
||
| - [ ] **Are there sufficient test cases?** Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components. If this is a bug fix, there must be a test case for the bug to ensure the issue won’t regress. | ||
|
|
There was a problem hiding this comment.
I would split bug fix into a separate check, and ask if the new tests break without the new code to fix it.
amplifi
approved these changes
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
This PR adds a review checklist to the pull request template. The checklist lists things to look out for. It might not be exhaustive, feel free to add anything that is missing.
When should this PR be merged
Anytime
Risks
None
Follow up actions
None