Fix #925 -- Remove project slug from file names #1000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Fixes #925.
We get this error with Unicode file names (e.g.
東京財団-line.shp
) because file names are encoded as a “surrogate escaped string” in a WSGI environment.It is possible to prevent this error from happening by either ignoring or replacing invalid characters when encoding to UTF-8.
Given the example above (
東京財団-line.shp
), ignoring invalid characters results in the file being added as-line.shp
to the download ZIP; replacing invalid characters results in??????????-line.shp
.I decided to remove the project name from file names altogether to ensure consistent naming independent of the project name.
When should this PR be merged
Anytime.
Risks
None.
Follow up actions
None.