Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions issue: Data Collector Role #960

Closed
clash99 opened this issue Dec 1, 2016 · 7 comments · Fixed by #1070
Closed

Permissions issue: Data Collector Role #960

clash99 opened this issue Dec 1, 2016 · 7 comments · Fixed by #1070

Comments

@clash99
Copy link
Contributor

clash99 commented Dec 1, 2016

Steps to reproduce the error

Based off this user's permissions (which I setup locally):
screenshot 2016-12-01 08 13 12

The user should have data collector rights to the Pekapuran Laut Test Project. Generally this user should have the ability to view/add/edit all locations, relationships, parties, resources, as well as import and download project data.

Actual behavior

I'm getting an alert that I don't have permission to import data. This new import data dropdown option is only available with PR #942. There isn't an option to download data. I think we need to revisit this from a UI perspective too. Maybe they should have a modified view of the ellipsis menu instead of removing it entirely.

screenshot 2016-12-01 10 30 31
screenshot 2016-12-01 10 30 44

Expected behavior

I should be able to import data if I'm a data collector.

@seav
Copy link
Contributor

seav commented Jan 4, 2017

Hmmm. I would expect that only project managers would be able to import data. I view data collectors as people given the permission to add/edit/delete records one at a time but not being able to bulk add records except through ODK.

@oliverroick oliverroick modified the milestone: Sprint 13 Jan 6, 2017
@oliverroick oliverroick self-assigned this Jan 9, 2017
@dpalomino
Copy link

Thanks @seav for the input. As just discussed, although in theory it makes sense to allow data collectors to import data, as it results in "collecting" new data into the project, in practice this is a task too complex to be performed by data collectors and it will be typically done by project managers. It could be too risky to allow all data collectors to perform this kind of tasks.

So I'd suggest to restrict import data just to project managers. Thoughts @clash99 @wonderchook @fhpichel?

@wonderchook
Copy link
Contributor

In agreement with that as far as the data collectors not doing imports

@oliverroick
Copy link
Member

@clash99 The "import data" link can be found in the "Add location" dropdown and the "More actions" dropdown. Is that correct or should it just be in one of the dropdowns?

@clash99
Copy link
Contributor Author

clash99 commented Jan 19, 2017

@oliverroick It is my understanding that Data Collectors cannot see the second "More Actions" button. Is that correct? Are you suggesting removing it from the "More Actions" menu?

#1027 addresses reworking these menus so perhaps we can remove it then. Also I think the questionnaire task will change these menus as well.

@oliverroick
Copy link
Member

Data collectors can not see the "More actions" button, that's correct. Was just checkin in if it's correct that the link appears in both menus. If so, we leave them in both and I just look at hiding the link when the user can't import.

@clash99
Copy link
Contributor Author

clash99 commented Jan 19, 2017

That sounds perfect - thank you @oliverroick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants