Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing Tools Do Not Show Up in Safari #858

Closed
wonderchook opened this issue Oct 24, 2016 · 5 comments
Closed

Drawing Tools Do Not Show Up in Safari #858

wonderchook opened this issue Oct 24, 2016 · 5 comments
Assignees
Milestone

Comments

@wonderchook
Copy link
Contributor

Steps to reproduce the error

Using Safari:

  1. Go to a project
  2. Click "Add Location"
  3. Drawing tools do not appear.

Expected behavior

Would expect drawing tools to show up the same as they do in Firefox and Chrome

@wonderchook
Copy link
Contributor Author

Appears to be an issue with Safari 9.1.3, not an issue with 10.0

@clash99
Copy link
Contributor

clash99 commented Oct 24, 2016

WIP notes:

  • Not a css issue, left controls are not being rendered
  • Looking into js but need to do some cleanup since looks like we are calling same file multiple times

screenshot 2016-10-24 12 24 12

  • This script is causing a typeerror in Safari 9.1.1:
<script>
 $(document).ready(function () {
   $(window).on('map:init', function(e) {
     map = add_map_controls(e.originalEvent.detail.map);
     map.fitBounds([[-45.0, -180.0], [45.0, 180.0]]);
   });
 });
</script>

@clash99
Copy link
Contributor

clash99 commented Oct 31, 2016

This is limited to Safari 9.0 and 9.1 with OSX. It

Console error:

screen shot 2016-10-31 at 3 43 28 pm

Safari 9.0 & 9.1 without fix (only zooms show):

screen shot 2016-10-31 at 3 55 27 pm

Safari 9.0 & 9.1 with proposed fix (default draw toolbar):

screen shot 2016-10-31 at 3 41 52 pm

In all other browsers (custom draw toolbar):

screen shot 2016-10-31 at 3 42 06 pm

@clash99
Copy link
Contributor

clash99 commented Nov 1, 2016

@wonderchook: I've done a lot of research trying to find a complete solution for this bug and haven't found one yet. Until then I propose showing the default leaflet draw toolbar for Safari 9.0 & 9.1 (right now nothing shows). The custom toolbar will still show for all other browsers. Do you have any thoughts on this proposed solution?

@oliverroick
Copy link
Member

I looked at this and opened PR #889 that fixes the issue and makes sure that the complete toolbar is displayed in Safari < 10.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants