Disabled org admin role dropdown causes field error

[linzjax]

Steps to reproduce the error

Go to an organization signed in as the organization administrator
Go to edit your member profile
Click save

Actual behavior

### Expected behavior

Messaging that explains why I cannot edit my own profile.

[seav]

Ah. Because of this report, I only learned now that disabled form fields are not submitted with the form. That is why you get the required error message. Apparently, the correct attribute should be readonly.

[oliverroick]

I don't like the idea of disabling a field or making it read-only. For usability, wouldn't it be better not to display the role field and the remove button at all? Instead we can just display the role and use a hidden field for the admin role to prevent errors when submitting the form. @clash99, opinions?

Then there is something funny about these lines. org_admin is used in the template to work out whether the user can change the organization role or not. For superusers, the condition becomes False, therefore superusers can change the field’s value. After the form is submitted, an error is shown that they can’t change the role. Which one is correct, @wonderchook?

[clash99]

Looking at this again I think a better interface might be to remove the gray box with the button and note completely. I would add a "?" next to the Role field and then @bethschechter can add help text containing this note and other role info. I think it'll make it simpler and less confusing.

Once we get the modals completed for the dropdown change, I also need to move that save button to be over the right side again. (More of a note-to-self)

[wonderchook]

I think the superuser should be able to do anything. That is why there are
so few superusers.

On Tue, Oct 25, 2016 at 1:01 PM, Oliver Roick [email protected]
wrote:

I don't like the idea of disabling a field or making it read-only. For
usability, wouldn't it be better not to display the role field and the
remove button at all? Instead we can just display the role and use a hidden
field for the admin role to prevent errors when submitting the form.
@clash99 https://github.com/clash99, opinions?

Then there is something funny about these lines
https://github.com/Cadasta/cadasta-platform/blob/master/cadasta/organization/views/default.py#L247-L249.
org_admin is used in the template to work out whether the user can change
the organization role or not. For superusers, the condition becomes False,
therefore superusers can change the field’s value. After the form is
submitted, an error is shown that they can’t change the role. Which one is
correct, @wonderchook https://github.com/wonderchook?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#823 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEJmNEub69QCgbR0ffzsWDaUsstjxCsks5q3jYFgaJpZM4KWPkH
.

Kate Chapman
Chief Technology Officer // Cadasta
[email protected] /__/ +1 703 673 8834
cadasta.org // @CadastaOrg http://twitter.com/CadastaOrg

[linzjax]

This issue has already been addressed. Should we close it?

[oliverroick]

I think it was addressed when you reworked that area, @linzjax?!

[linzjax]

Yeah... I just forgot about this issue... 😂

[clash99]

It appears fixed. I'm going to add some css around the "Role Administratior" to it so it appears less confusing. I'll assign it to myself.

[clash99]

Any idea on when we are going to get avatars into the platform? Should we hide this too? It does reinforce its a person (with a perfectly round head). Just a thought.

[clash99]

Separated Administrator from Role for clarity: