Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When user has no full name empty space there on top of that users' username in organization member side menu #758

Closed
kavindya89 opened this issue Oct 2, 2016 · 8 comments
Labels

Comments

@kavindya89
Copy link
Contributor

Steps to reproduce the error

Add a user without a full name
Go to organization and add him as a member and go to organization page again

Actual behavior

Empty space on top of user name

Expected behavior

If full name is not present show user name
bug

kavindya89 added a commit to kavindya89/cadasta-platform that referenced this issue Oct 2, 2016
kavindya89 added a commit to kavindya89/cadasta-platform that referenced this issue Oct 2, 2016
@kavindya89
Copy link
Contributor Author

Hi @oliverroick @ian-ross
I have added a fix. Please review.

@kavindya89
Copy link
Contributor Author

bug2

@clash99
Copy link
Contributor

clash99 commented Oct 5, 2016

Can we reverse the username and full name so that it won't be as strange if they don't have a username?

screenshot 2016-10-05 13 59 16

@seav
Copy link
Contributor

seav commented Oct 5, 2016

@clash99, I agree. Since the username is always present, and the full name is optional, it makes sense to show the username first and only have an optional second line for the full name.

@kavindya89
Copy link
Contributor Author

@clash99 @seav sure I will do that

kavindya89 added a commit to kavindya89/cadasta-platform that referenced this issue Oct 6, 2016
@kavindya89
Copy link
Contributor Author

@clash99 @seav updated pull request with requested changes.

@kavindya89
Copy link
Contributor Author

screen234

kavindya89 added a commit to kavindya89/cadasta-platform that referenced this issue Oct 6, 2016
ian-ross pushed a commit that referenced this issue Oct 10, 2016
ian-ross added a commit that referenced this issue Oct 10, 2016
* fixing #758

* adjusting changes as per comments in the ticket
@ian-ross
Copy link
Contributor

Fixed by #809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants