Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geopoint parse failure when there are also geotrace and geoshape questions in xlsform #643

Closed
bjohare opened this issue Sep 5, 2016 · 3 comments
Closed

Geopoint parse failure when there are also geotrace and geoshape questions in xlsform #643

bjohare opened this issue Sep 5, 2016 · 3 comments
Assignees
@bjohare
Labels
bug priority: high regression
Milestone
Sprint 8

Comments

@bjohare
Copy link
Contributor

bjohare commented Sep 5, 2016

Steps to reproduce the error

Try to submit to a form that has geotrace, geoshape and geopoint typed questions. See here for an example.

Actual behavior

Throws a 400 error where the exception is list index out of range.

Expected behavior

Form should submit successfully.
@bjohare bjohare added the bug label Sep 5, 2016
@bjohare
Copy link
Contributor Author

bjohare commented Sep 5, 2016

See https://github.com/Cadasta/cadasta-platform/blob/master/cadasta/xforms/mixins/model_helper.py#L79. The following line should be geotrace=False

Also wondering if this database query is required? https://github.com/Cadasta/cadasta-platform/blob/master/cadasta/xforms/mixins/model_helper.py#L70

@seav seav added the xlsforms label Sep 6, 2016
@dpalomino
Copy link

Thanks @bjohare for checking this and help to find out what was going on!

Is it possible to try to fix this in this milestone (if it's not too difficult)? I think it's important for several partners...

@bjohare bjohare self-assigned this Sep 6, 2016
@wonderchook wonderchook added this to the Sprint 8 milestone Sep 6, 2016
bjohare pushed a commit that referenced this issue Sep 7, 2016
Fixing #643
a61f9eb
@bjohare bjohare mentioned this issue Sep 7, 2016
Merged
ian-ross added a commit that referenced this issue Sep 7, 2016
@ian-ross
Merge pull request #648 from Cadasta/bugfix/#643
47efe6a 
Fixing #643
@bjohare
Copy link
Contributor Author

bjohare commented Oct 4, 2016

This has reappeared in the latest master.

@bjohare bjohare reopened this Oct 4, 2016
bjohare pushed a commit that referenced this issue Oct 7, 2016
Fix for #643
2586395 
* Fix failure to parse geopoint if geoshape question in form
* Re-factored ODK geom to WKT parsing
bjohare pushed a commit that referenced this issue Oct 7, 2016
Fix for #643
a5510b8 
* Fix failure to parse geopoint if geoshape question in form
* Re-factored ODK geom to WKT parsing
bjohare pushed a commit that referenced this issue Oct 7, 2016
Fix for #643
5d7263f 
* Fix failure to parse geopoint if geoshape question in form
* Re-factored ODK geom to WKT parsing
* Fix logging for xform submissions
@bjohare bjohare mentioned this issue Oct 7, 2016
Merged
ian-ross pushed a commit that referenced this issue Oct 10, 2016
Fix for #643
e47181d 
* Fix failure to parse geopoint if geoshape question in form
* Re-factored ODK geom to WKT parsing
* Fix logging for xform submissions
ian-ross pushed a commit that referenced this issue Oct 10, 2016
@bjohare @ian-ross
Fix for #643 (#808)
82c70fc 
* Fix failure to parse geopoint if geoshape question in form
* Re-factored ODK geom to WKT parsing
* Fix logging for xform submissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjohare bjohare

Labels
bug priority: high regression
Projects
None yet
Milestone
Sprint 8
Development

No branches or pull requests
5 participants
@wonderchook @seav @ian-ross @bjohare @dpalomino