Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use username in place of empty full name #626

Closed
clash99 opened this issue Aug 31, 2016 · 6 comments
Closed

Use username in place of empty full name #626

clash99 opened this issue Aug 31, 2016 · 6 comments
Labels
bug priority: low ui/ux
Milestone
Sprint 10

Comments

@clash99
Copy link
Contributor

clash99 commented Aug 31, 2016

Steps to reproduce the error

Member permissions page (under Organizations > Members > Select specific user)

Since username is required and full name isn't, we should use username instead of (or in place of) full name in member permissions title.

Actual behavior

When full name isn't present, title is empty behind "Member:"

Expected behavior

Would have expected username to show in cases of empty full name field.
@wonderchook wonderchook added this to the Sprint 9 milestone Aug 31, 2016
@seav seav added the bug label Sep 6, 2016
@wonderchook wonderchook modified the milestones: Sprint 10, Sprint 9 Sep 8, 2016
@kavindya89
Copy link
Contributor

I'll work on this. This will be my first issue as a contributor. :)

@oliverroick
Copy link
Member

Great!

@kavindya89
Copy link
Contributor

@oliverroick @clash99 I noticed one more thing. In member list page when there isn't full name member first column. I'll fix that as well :)

kavindya89 added a commit to kavindya89/cadasta-platform that referenced this issue Sep 10, 2016
@kavindya89
Fix for show username in member permissions page
f30b9f7 
The issue Cadasta#626 suggest that if full name is empty
then username should be set in member permission page. This pull request contains fix for it as well as
member list page, when full name is empty member column gets blank. So I include to display username if full name is not
present
@kavindya89 kavindya89 mentioned this issue Sep 10, 2016
Closed
@kavindya89
Copy link
Contributor

Hi All,

I submit a pull request. Since this is my first pull request for the project, it may need changes. Appreciate your suggestions. Attached images as well.

Thanks you

@kavindya89
Copy link
Contributor

screen1
screen2

@kavindya89
Copy link
Contributor

The user Geshani don't have a full name :)

kavindya89 added a commit to kavindya89/cadasta-platform that referenced this issue Sep 14, 2016
@kavindya89
Fix for show username in member permissions page
14dd1c3 
The issue Cadasta#626 suggest that if full name is empty
then username should be set in member permission page. This pull request contains fix for it as well as
member list page, when full name is empty member column gets blank. So I include to display username if full name is not
present
kavindya89 added a commit to kavindya89/cadasta-platform that referenced this issue Sep 14, 2016
@kavindya89
Fix for show username in member permissions page
6657275 
The issue Cadasta#626 suggest that if full name is empty
then username should be set in member permission page. This pull request contains fix for it as well as
member list page, when full name is empty member column gets blank. So I include to display username if full name is not
present
kavindya89 added a commit to kavindya89/cadasta-platform that referenced this issue Sep 14, 2016
@kavindya89
Fix for show username in member permissions page
a02df45 
The issue Cadasta#626 suggest that if full name is empty
then username should be set in member permission page. This pull request contains fix for it as well as
member list page, when full name is empty member column gets blank. So I include to display username if full name is not
present
kavindya89 added a commit to kavindya89/cadasta-platform that referenced this issue Sep 14, 2016
@kavindya89
Fix for show username in member permissions page
b27043a 
The issue Cadasta#626 suggest that if full name is empty
then username should be set in member permission page. This pull request contains fix for it as well as
member list page, when full name is empty member column gets blank. So I include to display username if full name is not
present
kavindya89 added a commit to kavindya89/cadasta-platform that referenced this issue Sep 14, 2016
@kavindya89
Fix for show username in member permissions page
3179715 
The issue Cadasta#626 suggest that if full name is empty
then username should be set in member permission page. This pull request contains fix for it as well as
member list page, when full name is empty member column gets blank. So I include to display username if full name is not
present
@kavindya89 kavindya89 mentioned this issue Sep 14, 2016
Merged
kavindya89 added a commit to kavindya89/cadasta-platform that referenced this issue Sep 14, 2016
@kavindya89
Fix for show username in member permissions page
aade6c2 
The issue Cadasta#626 suggest that if full name is empty
then username should be set in member permission page. This pull request contains fix for it as well as
member list page, when full name is empty member column gets blank. So I include to display username if full name is not
present
ian-ross pushed a commit that referenced this issue Sep 14, 2016
@kavindya89 @ian-ross
Fix for show username in member permissions page (#687)
3d64c5a 
The issue #626 suggest that if full name is empty
then username should be set in member permission page. This pull request contains fix for it as well as
member list page, when full name is empty member column gets blank. So I include to display username if full name is not
present
@kavindya89 kavindya89 mentioned this issue Oct 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority: low ui/ux
Projects
None yet
Milestone
Sprint 10
Development

No branches or pull requests
5 participants
@wonderchook @oliverroick @seav @clash99 @kavindya89