Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to select "All Types" for relationship type #588

Closed
ian-ross opened this issue Aug 23, 2016 · 4 comments
Closed

Possible to select "All Types" for relationship type #588

ian-ross opened this issue Aug 23, 2016 · 4 comments
Assignees
Milestone

Comments

@ian-ross
Copy link
Contributor

When you create a relationship for a location, it's possible to select "All Types" from the relationship type dropdown list. You then end up with a relationship with type "All Types". Is this really right? I would have thought that you need to select a specific relationship type.

(This is a result of https://github.com/Cadasta/cadasta-platform/blob/master/cadasta/party/models.py#L289.)

@seav
Copy link
Contributor

seav commented Aug 23, 2016

I'm not sure if this is the behavior since the very beginning, or if this is a regression. I saw the following screenshot before where "All Types" generates a required field error message but I don't know if this screenshot is a mockup or actual behavior that has now regressed:

Screenshot

@wonderchook
Copy link
Contributor

Actually, sorry no looking in the wrong place. It would seem to me there wouldn't be a tenure type "All Types". @fhpichel and @nastynoel can you confirm this?

@nastynoel
Copy link

Correct.

Can we take this opportunity to expand the list of possible relationship
and location types?

On Aug 24, 2016 02:57, "Kate Chapman" [email protected] wrote:

Actually, sorry no looking in the wrong place. It would seem to me there
wouldn't be a tenure type "All Types". @fhpichel
https://github.com/fhpichel and @nastynoel
https://github.com/nastynoel can you confirm this?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#588 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOLqSiw_Hv7nm7EyQ8Wcsa43HWGFlwGUks5qiyY5gaJpZM4Jq___
.

@wonderchook
Copy link
Contributor

@nastynoel please open a new ticket for that.

I've marked this as a bug and we should fix it as we have time.

@ian-ross ian-ross self-assigned this Aug 25, 2016
ian-ross pushed a commit that referenced this issue Aug 31, 2016
Remove AL entry from tenure relationship type list.  Modify tests
accordingly.  Add data migration to convert any existing AL
relationships to FH (freehold) and to remove the AL entry from the
TenureRelationshipType table in the database.
ian-ross pushed a commit that referenced this issue Aug 31, 2016
Remove AL entry from tenure relationship type list.  Modify tests
accordingly.  Add data migration to convert any existing AL
relationships to FH (freehold) and to remove the AL entry from the
TenureRelationshipType table in the database.
@seav seav closed this as completed in 3fd163f Aug 31, 2016
seav added a commit that referenced this issue Aug 31, 2016
Fix #588: filter "All Types" from tenure type list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants