Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benghali font replacement #585

Closed
clash99 opened this issue Aug 23, 2016 · 12 comments
Closed

Benghali font replacement #585

clash99 opened this issue Aug 23, 2016 · 12 comments
Assignees
Milestone

Comments

@clash99
Copy link
Contributor

clash99 commented Aug 23, 2016

Steps to reproduce the error

Look at staging site organization index

Actual behavior

Unreadable font for Benghali organization

Expected behavior

Fonts are replaced to be readable instead of boxes

Current:
screenshot 2016-08-23 08 40 01

Expected:
screenshot 2016-08-23 08 41 49

@clash99 clash99 self-assigned this Aug 23, 2016
@seav
Copy link
Contributor

seav commented Aug 23, 2016

As mentioned by @ian-ross in Slack, this can be remedied by using web fonts. We really cannot expect users to have fonts installed for all possible Unicode scripts.

@wonderchook
Copy link
Contributor

How difficult is this to fix? @fhpichel is headed to Bangladesh so it would be good to tidy this up.

@wonderchook wonderchook added this to the Sprint 7 milestone Aug 23, 2016
@clash99
Copy link
Contributor Author

clash99 commented Aug 24, 2016

Not hard, I'll look at it this evening.

@clash99
Copy link
Contributor Author

clash99 commented Aug 24, 2016

Spoke too soon - I don't think there is anything we can do. Its a browser-based issue so fixes are available for the user to change the default font for their preferred browser.

I'm trying to brainstorm if there is another way. If we knew the project/org font was benghali, we could force a font substitution on our side via css but we currently don't have any way of knowing that and I'm not sure it would be that easy. I'm totally open for other ideas on this one...

Is it currently broken for @fhpichel? If so, I can reach out to assist him on getting it fixed on his browser.

@seav
Copy link
Contributor

seav commented Aug 24, 2016

Couldn't a fallback font in the CSS work for this? https://en.wikipedia.org/wiki/Fallback_font

@wonderchook
Copy link
Contributor

One thought is that most Bengali speakers would be likely to have the right font installed. (I'm guessing here)

@wonderchook wonderchook modified the milestones: Sprint 8, Sprint 7 Aug 24, 2016
@dpalomino
Copy link

Hi,

I've just checked in my laptop with Chrome, Firefox and Safari (for desktop), and for Chrome for Android, and with all of them is working fine.

Thanks!
David

@seav
Copy link
Contributor

seav commented Aug 24, 2016

Regarding the fallback fonts. It's in the CSS specification that when you list a bunch of fonts in the font-family CSS property and the more preferred font does not have a glyph for a character, it will try the remaining fonts in turn until it finds one that does have a glyph. Otherwise, it will display the "missing character" glyph.

So there is no need to detect which language or script our organization or project names are using. Just provide a list of fonts in font-family that covers all of our likely Unicode scripts that can be used.

@ian-ross
Copy link
Contributor

There's this, which has glyphs for all of the Unicode basic multilingual plane (which covers most languages currently in use): https://en.wikipedia.org/wiki/GNU_Unifont I've been trying to find a webfont version of it, without luck though.

@clash99
Copy link
Contributor Author

clash99 commented Sep 2, 2016

I have found this font replacement to be the best even though its only in ttf format: Noto Sans Bengali
https://www.google.com/get/noto/#sans-beng

screenshot 2016-09-02 17 48 25

I would like for someone who was seeing the hex boxes to confirm that this is working correctly for them.

ian-ross added a commit that referenced this issue Sep 6, 2016
Noto Sans Bengali font for Bengali replacement
@seav
Copy link
Contributor

seav commented Sep 8, 2016

Is this issue closed by #639? Note @clash99's request above: "I would like for someone who was seeing the hex boxes to confirm that this is working correctly for them."

@ian-ross
Copy link
Contributor

ian-ross commented Sep 9, 2016

I checked it and commented when I merged the PR, but I guess the PR didn't have the magic to close the issue. Anyway, it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants