Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default form submit in step 2 or 3 of the add project wizard is the Previous button #525

Closed
seav opened this issue Aug 5, 2016 · 0 comments
Assignees
Milestone

Comments

@seav
Copy link
Contributor

seav commented Aug 5, 2016

Expected behavior

While a form input is focused in either step 2 or 3 of the add-project wizard, pressing the Enter key to submit the form should go to the wizard's next step.

Actual behavior

The wizard goes to the previous step instead.

Steps to reproduce the error

Example steps (can have many variations):

  1. Go to the add-project wizard
  2. Go to step 2
  3. Enter some name in the Project name field
  4. While the Project name field is still focused, press the Enter key
  5. The page that appears is step 1 instead of the expected step 3

Notes

Because the previous button appears first in the HTML form, this becomes the form's default submit action. Based on some Googling, the only solution seems to be to exchange the order of the buttons and then reverse the order via CSS, and also exchanging the keyboard tab order.

Another solution is to have an invisible duplicate of the Next submit button before the Previous button.

@ian-ross ian-ross added this to the Sprint 7 milestone Aug 8, 2016
@ian-ross ian-ross self-assigned this Aug 9, 2016
oliverroick added a commit that referenced this issue Aug 9, 2016
Fix #525: "Next" button is default in wizard steps
@oliverroick oliverroick mentioned this issue Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants