Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard map not centered over points being displayed #213

Closed
linzjax opened this issue Jun 3, 2016 · 6 comments
Closed

Dashboard map not centered over points being displayed #213

linzjax opened this issue Jun 3, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@linzjax
Copy link
Contributor

linzjax commented Jun 3, 2016

The Pekapuran Laut Test Project is not being displayed on the dashboard because the pin is being placed on the Asian on the left-hand side, not the Asian that's centered in the viewport. If you move to the left on the map you can see it.

@wonderchook wonderchook added this to the Version 0.1 milestone Jun 15, 2016
@linzjax
Copy link
Contributor Author

linzjax commented Jun 16, 2016

So it looks like the UI is restricting which set of continents the user can access by snapping those back into center if they try to drag away from them. Since I import geojson points for the Pekapuran Laut Test Project, I didn't have these same constraints. If people are going to be import geojson we might want to find a way to translate those points.

@linzjax linzjax self-assigned this Jun 20, 2016
@jnordling
Copy link
Member

I also on the page where you create a new project. I felt from a user perspective that it was too far zoomed out. Maybe only show the bulk of one earth. Thats what you would except to see at least.

linzjax added a commit that referenced this issue Jun 21, 2016
Added js filter that converts points outside of the center map bounds to fit within it.
Also converts extents in project view so they're now displayed on the map.
This feels like a temporary fix and could cause problems if people then add spatial units in the UI.
linzjax added a commit that referenced this issue Jun 23, 2016
added logic into model to check if project extent is within the map bounds
linzjax added a commit that referenced this issue Jun 23, 2016
added logic into model to check if project extent is within the map bounds
linzjax added a commit that referenced this issue Jun 23, 2016
added logic into model to check if project extent is within the map bounds

added bounding box for project_add_extents map
linzjax added a commit that referenced this issue Jun 23, 2016
added logic into model to check if project extent is within the map bounds

added bounding box for project_add_extents map
oliverroick added a commit that referenced this issue Jun 25, 2016
Fixes #213: Points are now centered on the map.
seav pushed a commit that referenced this issue Jun 27, 2016
added logic into model to check if project extent is within the map bounds

added bounding box for project_add_extents map
@linzjax
Copy link
Contributor Author

linzjax commented Jul 5, 2016

The project "Chickens Everywhere" managed to be created outside of the center map. @wonderchook : Did you create this project from a really zoomed out state?

so_many_chickens_off_the_map

@linzjax linzjax reopened this Jul 5, 2016
@wonderchook
Copy link
Contributor

Hmmm apparently that is exactly what I did, reproduced it.

more-chickens

@seav
Copy link
Contributor

seav commented Jul 7, 2016

I think this is because the staging environment does not yet contain the out-of-bound geometry check that @linzjax added.

@seav
Copy link
Contributor

seav commented Jul 7, 2016

I tried recreating this issue on the latest master and I can confirm that a project drawn outside of the "center" map gets re-placed within ±180° longitudes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants