Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHP download breaks when there are empty geometries #1373

Closed
oliverroick opened this issue Apr 4, 2017 · 4 comments · Fixed by #1439
Closed

SHP download breaks when there are empty geometries #1373

oliverroick opened this issue Apr 4, 2017 · 4 comments · Fixed by #1439

Comments

@oliverroick
Copy link
Member

Steps to reproduce the error

  1. Create a project that contains empty geometries (you can import data from import-2-questionnaire.zip
  2. Download data; select "SHP" or "All Data"

Actual behavior

Server error is thrown; see the corresponding log on Opbeat for more details.

Expected behavior

Data should be downloaded.

@dpalomino
Copy link

Also related to #1113 .

AFAIK, there are no projects with empty geometries yet, but as we will allow them through imports as discussed in #1254, so I think we need to fix this (although not super urgent).

@Sanny26
Copy link
Contributor

Sanny26 commented Apr 4, 2017

I'm trying to reproduce this error. When I try to import a file in zip, it throws a tuple index out of range error and a warning on select import field page(step 2)
screenshot from 2017-04-05 01 04 43

Am I doing anything wrong?

@oliverroick
Copy link
Member Author

@Sanny26 Have you loaded the questionnaire in the Zip first and then tried to import the data?

@dpalomino
Copy link

To be addressed in Sprint 17

amplifi pushed a commit that referenced this issue May 17, 2017
* Fix #1373 -- Ignore empty geometries for SHP export

* Add test for `geometry=None`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants