Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail table to resource detail page #1267

Open
clash99 opened this issue Mar 9, 2017 · 15 comments
Open

Add detail table to resource detail page #1267

clash99 opened this issue Mar 9, 2017 · 15 comments
Assignees
Labels

Comments

@clash99
Copy link
Contributor

clash99 commented Mar 9, 2017

For our users with slower connections, it would be good for them to know the file sizes of our resources before they choose to download them. Also any additional information we could give them before downloading would be helpful. I suggest adding a detail table similar to the mock below and making a few adjustments to the page title to match the party detail page. Some fields such as dimension wouldn't be shown for files that weren't images.

screenshot 2017-03-23 11 19 01

I can see us wanting to add file size next to the resource name in other pages on the platform too.

@clash99
Copy link
Contributor Author

clash99 commented Mar 9, 2017

@oliverroick and @amplifi - before I create any mocks for this, can you let me know if this is able to be first-contributor friendly or are there security concerns or other issues I'm not aware of? Thanks!

@amplifi
Copy link
Contributor

amplifi commented Mar 10, 2017

@clash No issues here 👍

@clash99 clash99 self-assigned this Mar 10, 2017
@aadityasg
Copy link

@clash99 @amplifi Is there any pending discussion on this issue? Or we intend to display download size next to various options on export page before user actually downloads the file?

image

@clash99
Copy link
Contributor Author

clash99 commented Mar 20, 2017

@aadityasg Sorry, not ready for this one yet.

@clash99
Copy link
Contributor Author

clash99 commented Mar 23, 2017

@aadityasg That would be a great idea too but this task is for individual resources, not the downloading of multiple. I'm hoping to put more requirements for this together today. I will also pass on this idea to our project owner since I believe its a good idea. Thanks!

@dpalomino - see note above about including file sizes when downloading project data.

@clash99 clash99 changed the title Identify resource file size Add detail table to resource detail page Mar 23, 2017
@clash99
Copy link
Contributor Author

clash99 commented Mar 23, 2017

I've updated the title and description of this task to better match what we are trying to do.

@dpalomino - I'm marking this first-contributor friendly. Please remove if you disagree.

@dpalomino
Copy link

Thanks @clash99! Yes I agree.

I think we should show the size of "Resources" and "All data" in Download project data:

screen shot 2017-03-23 at 17 56 25

And in the details of each individual resources (probably a line before "Added on..."):

screen shot 2017-03-23 at 17 56 57

@clash99
Copy link
Contributor Author

clash99 commented Mar 23, 2017

It sounds good but I'm not sure if we know the file sizes ahead of time for the data download options. I think we should add anything outside of the resource detail page in another task for investigation. Sound reasonable @dpalomino?

@seav
Copy link
Contributor

seav commented Mar 23, 2017

I would strongly advise against including the file size for the project data download feature. To get this information, we would need to actually generate the files to be downloaded for all options, potentially wasting CPU cycles and S3 accesses for resources in case the user decides to cancel.

@clash99
Copy link
Contributor Author

clash99 commented Mar 23, 2017

I was thinking that might be the case @seav. Thanks for clarifying.

@dpalomino
Copy link

Thanks for the heads-up @seav, I wasn't aware of this complication. Let's then go with the original proposal for the individual resources only (unless we can find out a workaround to estimate an approximate size for downloading all the resources).

@EkaterinaSemenova
Copy link

As far as I understand, to implement this feature we need to add additional properties (e.g. file_size, image_dimensions etc.) to either Resource model or underlying S3File. Which way sounds more reasonable for you?

@khantaalaman
Copy link
Contributor

@clash99 @seav A PR has been submitted for this issue. Please review whenever possible.

Thanks!

@amplifi
Copy link
Contributor

amplifi commented Mar 28, 2017

@clash99 @dpalomino @seav It would actually be trivial to obtain reasonable file size estimates for all resources and all project data downloads. S3 maintains metadata including file size and type, so files shouldn't need to be downloaded to obtain a size estimate. However, this would be inefficiently handled under the current platform code and should be included in the async I/O work.

@dpalomino
Copy link

Thanks a lot @amplifi. It'd be great if we can include it in the async i/o yes (#490).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants