-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detail table to resource detail page #1267
Comments
@oliverroick and @amplifi - before I create any mocks for this, can you let me know if this is able to be first-contributor friendly or are there security concerns or other issues I'm not aware of? Thanks! |
@clash No issues here 👍 |
@aadityasg Sorry, not ready for this one yet. |
@aadityasg That would be a great idea too but this task is for individual resources, not the downloading of multiple. I'm hoping to put more requirements for this together today. I will also pass on this idea to our project owner since I believe its a good idea. Thanks! @dpalomino - see note above about including file sizes when downloading project data. |
I've updated the title and description of this task to better match what we are trying to do. @dpalomino - I'm marking this first-contributor friendly. Please remove if you disagree. |
Thanks @clash99! Yes I agree. I think we should show the size of "Resources" and "All data" in Download project data: And in the details of each individual resources (probably a line before "Added on..."): |
It sounds good but I'm not sure if we know the file sizes ahead of time for the data download options. I think we should add anything outside of the resource detail page in another task for investigation. Sound reasonable @dpalomino? |
I would strongly advise against including the file size for the project data download feature. To get this information, we would need to actually generate the files to be downloaded for all options, potentially wasting CPU cycles and S3 accesses for resources in case the user decides to cancel. |
I was thinking that might be the case @seav. Thanks for clarifying. |
Thanks for the heads-up @seav, I wasn't aware of this complication. Let's then go with the original proposal for the individual resources only (unless we can find out a workaround to estimate an approximate size for downloading all the resources). |
As far as I understand, to implement this feature we need to add additional properties (e.g. file_size, image_dimensions etc.) to either Resource model or underlying S3File. Which way sounds more reasonable for you? |
@clash99 @dpalomino @seav It would actually be trivial to obtain reasonable file size estimates for all resources and all project data downloads. S3 maintains metadata including file size and type, so files shouldn't need to be downloaded to obtain a size estimate. However, this would be inefficiently handled under the current platform code and should be included in the async I/O work. |
For our users with slower connections, it would be good for them to know the file sizes of our resources before they choose to download them. Also any additional information we could give them before downloading would be helpful. I suggest adding a detail table similar to the mock below and making a few adjustments to the page title to match the party detail page. Some fields such as dimension wouldn't be shown for files that weren't images.
I can see us wanting to add file size next to the resource name in other pages on the platform too.
The text was updated successfully, but these errors were encountered: