Error messages during organization creation are not cleared

[amplifi]

Steps to reproduce the error

Attempt to create an organization with an empty name. It will show you the appropriate empty name error message. Then enter an organization name that already exists.

Actual behavior

Both error messages appear simultaneously. (The same error occurs no matter which order you trigger them in succession.)

Expected behavior

Any visible error message should be cleared upon clicking "Save", so that only the applicable error message appears after a new error is found. Also "Name" in the "Organization with this Name already exists" error message should be lowercase.

[khantaalaman]

The bug has been fixed.

Supporting GIF:

PS: Sorry for buggy GIFs.

[oliverroick]

Just curious, is that something that happens in other forms as well? Say the project form for example? If yes, we need a generic solution that works across all forms and all fields.

[khantaalaman]

Cool @oliverroick , I will look into this and update the PR accordingly. By the way, I anyway need to update the PR for making the work "Name" lowercase. Sorry to have skipped that by mistake.

Thanks!

[dpalomino]

To be tested if that is reproducible in other forms (like for projects).

[dpalomino]

Retested in the forms for creating projects. Interestingly behaviour is slightly different:

1. Trying to create an empty name project > proper error message shown ("This field is required")
2. Trying to use an existing name > Error message is cleared and proper message is shown ("Project with this name already exists in this organization")

However inverting the order (first use an existing name and then try to use an empty name) presents both error messages:

I think this is a much more corner case.

[khantaalaman]

Hi @dpalomino, the PR has been updated and now takes care of error messages while creating a new project.
Perhaps, as @oliverroick mentioned about having a generic solution taking care of all forms and related fields, I believe we should add a similar logic ( as in PR ) to one of the js files instead of specific .html files. In case we are going for that, I was planning to add necessary piece of code in form_submit_once.js file. Is doing so the best choice or there can be a better way?
Also, I tried but couldn't find the file which is responsible for showing "Name" instead of "name" in the error message. It would be really grateful of someone who can point out that particular file. Once found, we will also need to make necessary changes in test_duplicate_name_error in test_forms.py.

Looking forward to completely fix this issue.

Thanks! :)

[yoshi2095]

@khantaalaman it's in cadasta/organization/tests/test_forms.py line 68. Please correct me if I am wrong. @dpalomino @oliverroick

[khantaalaman]

@yoshi2095 I have already mentioned it as the location where we would have to make the change and it's a test.

`Once found, we will also need to make necessary changes in test_duplicate_name_error in test_forms.py

I am not getting the file responsible for the feature itself and not the test.

Thanks for searching it btw. :)

[oliverroick]

We're using Parsley to do client-side form validation. There might be a way to make Parsley use the same element to display error messages that Django does. That way you can have Parsley take care of the problem and it will be added to all forms.

If that's not possible, you can add that functionality to form_submit_once but I would then rename the file to a more generic name because it handles different aspects of form submission.

[dpalomino]

@clash99 volunteered to take a look, thanks!

[clash99]

This string isn't translated in current format so added explicit validation message. Other languages will be translated once transifex is updated.