Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: clicking on search panel should go to the top of the page? #1148

Closed
dpalomino opened this issue Feb 21, 2017 · 9 comments
Closed

Search: clicking on search panel should go to the top of the page? #1148

dpalomino opened this issue Feb 21, 2017 · 9 comments

Comments

@dpalomino
Copy link

This is a really low prio issue, just in case it could improve usability.

Steps to reproduce:

  1. Execute a search query resulting in many results
  2. Going to the end of the query list (where the pagination is)
  3. Click on search icon on the left panel.

Current behaviour:

Nothing happens

Expected behaviour:

I think if the user would be redirected to the top of the page (where the search box is), usability would be better.

What do you think @clash99?

@clash99
Copy link
Contributor

clash99 commented Feb 21, 2017

@dpalomino sounds good - perhaps this would be first-contribution friendly?

@dpalomino
Copy link
Author

@dpalomino sounds good - perhaps this would be first-contribution friendly?

Great idea. Adding label :-)

@jinankjain
Copy link

@dpalomino I was looking at bug status. Right now I don't find any search button. Do you want to create a search button and link to search at the top.

screen shot 2017-02-24 at 1 50 22 pm

@Sarthak30
Copy link

Hi,
I am new here. As a beginner, I would love to solve this bug. Please, guide me how to get started with project setup.

@oliverroick
Copy link
Member

@jinankjain This is referring to the button in the left-hand side menu:

screen shot 2017-02-28 at 09 43 31

@oliverroick
Copy link
Member

@Sarthak30 Please have a look at the repository's README, it contains instructions how to set up the development environment

@dvlshah
Copy link

dvlshah commented Feb 28, 2017

@oliverroick Do we have to add search button that remains on left hand side when user scroll down project lists and when user clicks it ,it should redirect it to top search bar?

@oliverroick
Copy link
Member

@dvlshah This applies only to the search in a project. I.e. when you click search (see the screenshot above), you enter a term, you are being redirected to the page with all results, you scroll down and when you click the search button again you will stay on that page but the page jumps back to the top where you can enter a new search.

@maitreyaverma
Copy link

I have added a pull request that fixes this issue. Looking forward for your feedback on it.

@iharsh234 iharsh234 mentioned this issue Mar 2, 2017
iharsh234 added a commit to iharsh234/cadasta-platform that referenced this issue Mar 27, 2017
amplifi pushed a commit to iharsh234/cadasta-platform that referenced this issue Apr 3, 2017
@amplifi amplifi closed this as completed in f62ac8e Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants