Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon lookups for audio files fail #1013

Closed
oliverroick opened this issue Dec 19, 2016 · 3 comments · Fixed by #1029
Closed

Icon lookups for audio files fail #1013

oliverroick opened this issue Dec 19, 2016 · 3 comments · Fixed by #1029

Comments

@oliverroick
Copy link
Member

Steps to reproduce the error

In settings, we have defined a dict (MIME_LOOKUP) to lookup the thumbnail icon for the resource's mime type. The corresponding thumbnail images are stored on our production S3 bucket.

For of the audio mime types, the lookup will fail because there is not file in the bucket. For mime type audio/3gppthere is no file called 3gpp.png in the bucket.

Actual behavior

See above.

Expected behavior

For each of the mime types the corresponding icon file should exist in our production buckets. I suggest to create a generic audio file icon (so far we have mp3 and mp4) the we use for all audio types.

@clash99
Copy link
Contributor

clash99 commented Dec 19, 2016

Do we just need a 3gpp.png or are there others? I can also make a generic "audio" png.

@clash99 clash99 self-assigned this Dec 19, 2016
@clash99
Copy link
Contributor

clash99 commented Dec 19, 2016

There is a new 3GPP and AUDIO png added here: https://drive.google.com/drive/folders/0BzpiEtMtHC3rbXRya0FiVVU2bm8?usp=sharing

Let me know if any others need to be created.

@oliverroick
Copy link
Member Author

@clash99 Thanks for preparing those images.

If we want to have a custom icon for each of the audio types, we'd need create a whole heap of images, see here. That's why I thought we'd go with a generic audio icon for all the less common formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants