Fix migration failure (#1737)

* Fix migration failure Fix bug where migration fails if no spatial units are associated with project. * Add sanity test * Use ProjectFactory * Fixup * Flake8 cleanup
Cadasta · Aug 26, 2017 · 7b50f51 · 7b50f51
1 parent e32e6ee
commit 7b50f51
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/cadasta/organization/migrations/0006_add_project_area_trigger.py b/cadasta/organization/migrations/0006_add_project_area_trigger.py
@@ -19,7 +19,7 @@ class Migration(migrations.Migration):
     operations = [
         migrations.RunSQL(
             (
-                'UPDATE organization_project SET area = (SELECT sum(area) from spatial_spatialunit where "spatial_spatialunit".project_id = "organization_project".id)'
+                'UPDATE organization_project SET area = (SELECT COALESCE(sum(area), 0) from spatial_spatialunit where "spatial_spatialunit".project_id = "organization_project".id)'
             ),
             reverse_sql=migrations.RunSQL.noop
         ),

diff --git a/cadasta/organization/tests/test_migrations.py b/cadasta/organization/tests/test_migrations.py
@@ -30,7 +30,10 @@ def test_migration(self):
         call_command('migrate', 'organization', self.migrate_from)
 
         org = Organization.objects.create(name='Test Org')
-        project = Project.objects.create(name='Test Proj', organization=org)
+        Project.objects.create(
+            id=1, name='No Locations Proj', organization=org)
+        project = Project.objects.create(
+            id=2, name='Test Proj', organization=org)
 
         su1 = SpatialUnit.objects.create(
             id='abc',